update idmap config syntax

[aaptel]

idmap uid/gid is obsolete

samba tools like smbclient now warn about it:

linux-fp5a:~ # smbclient //localhost/users -U aaptel-ad%'xyz'
WARNING: The "idmap gid" option is deprecated
WARNING: The "idmap uid" option is deprecated

This commit simply changes what is written to the new syntax.

It probably needs more work to detect the old syntax in the case of reading a old smb.conf but I'm not even sure this is actually a usecase we have to handle? (we always overwrite the file no?)

[aaptel]

This issue has an open ticket on bugzilla bsc#873981

[jreidinger]

@ddiss can you please check it?

@aaptel changelog entry + version increase is needed. BTW will it work also on SLE12SP2 ( or opensuse 42.2 as it have same code base )? we currently share code between these two.

[aaptel]

I can confirm it works on SLE12SP2 but this probably needs more work because:

• the yast UI lets user choose different ranges for uid and gid (proposed change uses the same for both). we need to either remove that choice from the UI or add equivalent config
• if there is an existing smb.conf file with the deprecated syntax it will add the new one (and not remove the old one)

[ddiss]

I think changing the UI to only offer a single range would make sense here. Existing "idmap uid/gid" configs with matching ranges (a likely occurrence) could be safely converted to use the new parameter.
configs with non-matching ranges should not be affected by the change, but instruct administrators that manual configuration is required.

[teclator]

@aaptel what is the state of this PR?, do you plan to change the UI or work on it?

[teclator]

@aaptel @noelpower @ddiss almost two years have passed since the PR was created, could you please check if it is valid and add the missing changelog + version increase for being able to merge it? If not we will probably close it as no response from a while.

[ddiss]

It's still valid IMO, but needs work as per my last comment. I've updated the bug to track this for future releases

[teclator]

@ddiss thnx for taking care