Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkbox for the net ads join --no-dns-updates switch #48

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@aaptel
Copy link

commented Aug 19, 2016

SLE12SP2 net ads join utility has a new --no-dns-updates option (bsc#991564) this change adds a checkbox in the AD join popup and the autoyast UI to reflect that.

@aaptel

This comment has been minimized.

Copy link
Author

commented Aug 19, 2016

Actually, it's not done yet sorry. I'll update the PR when I'm done.

Aurelien Aptel
add checkbox for the net ads join --no-dns-updates switch
Signed-off-by: Aurelien Aptel <aaptel@suse.com>

@aaptel aaptel force-pushed the aaptel:dns_updates branch from ae3d587 to 1e6ffc9 Aug 19, 2016

@aaptel

This comment has been minimized.

Copy link
Author

commented Aug 19, 2016

Should be ok now.

@jreidinger

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

looks good, please update it to resolve conflict and bump version. Thanks

@teclator
Copy link
Contributor

left a comment

@aaptel it needs some small changes to be merged (bump version), change branch target from master to SLE12SP2 if still wanted and should be OK.

@teclator

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2018

@ddiss @aaptel what about this one, the requested changes are also waiting for one year at least.

@ddiss

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2018

Looks okay to me, although my preference would be to hide this a little more in the UI. @aaptel what do you think about moving this to the "Expert Settings" window?

@teclator

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2018

@aaptel I will close it by now, it needs some adaptations for being able to merge. Please, feel free to reopen it if you plan to adapt or just create a new one.

@teclator teclator closed this Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.