add checkbox for the net ads join --no-dns-updates switch #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, it's not done yet sorry. I'll update the PR when I'm done. |
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
|
Should be ok now. |
|
looks good, please update it to resolve conflict and bump version. Thanks |
|
Looks okay to me, although my preference would be to hide this a little more in the UI. @aaptel what do you think about moving this to the "Expert Settings" window? |
|
@aaptel I will close it by now, it needs some adaptations for being able to merge. Please, feel free to reopen it if you plan to adapt or just create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLE12SP2 net ads join utility has a new --no-dns-updates option (bsc#991564) this change adds a checkbox in the AD join popup and the autoyast UI to reflect that.