Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSE SAP HA Yast wizard for HANA doesn´t configure the HANA hooks. #7

Merged
merged 27 commits into from
Jun 9, 2022
Merged

SUSE SAP HA Yast wizard for HANA doesn´t configure the HANA hooks. #7

merged 27 commits into from
Jun 9, 2022

Conversation

varkoly
Copy link
Collaborator

@varkoly varkoly commented Oct 12, 2021

No description provided.

@coveralls
Copy link

coveralls commented Oct 12, 2021

Pull Request Test Coverage Report for Build 2460358656

  • 12 of 39 (30.77%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 29.303%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/sap_ha/configuration/cluster.rb 0 1 0.0%
src/lib/sap_ha/configuration/watchdog.rb 1 2 50.0%
src/lib/sap_ha/rpc_server.rb 2 3 66.67%
src/lib/sap_ha/system/network.rb 2 3 66.67%
src/lib/sap_ha/helpers.rb 1 3 33.33%
src/lib/sap_ha/system/watchdog.rb 1 3 33.33%
src/lib/sap_ha/configuration.rb 4 8 50.0%
src/clients/sap_ha.rb 0 7 0.0%
src/lib/sap_ha/system/hana.rb 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib/sap_ha/configuration/cluster.rb 1 62.7%
Totals Coverage Status
Change from base Build 1417482567: -0.4%
Covered Lines: 1224
Relevant Lines: 4177

💛 - Coveralls

@lslezak
Copy link
Member

lslezak commented Mar 28, 2022

Looks OK, just the SP3 fix also contains a change in the test/test_helper.rb file : https://github.com/yast/yast-sap-ha/pull/8/files#diff-ba37813ca277c227a74a372479b7b05b7f3ff085d890ab708f80d62573efdb7a

That is not needed in master?

@varkoly
Copy link
Collaborator Author

varkoly commented Apr 12, 2022

Looks OK, just the SP3 fix also contains a change in the test/test_helper.rb file : https://github.com/yast/yast-sap-ha/pull/8/files#diff-ba37813ca277c227a74a372479b7b05b7f3ff085d890ab708f80d62573efdb7a

That is not needed in master?

You've right. It is needed. Now I've added the required changes.

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 0e74ddd into yast:master Jun 9, 2022
@varkoly
Copy link
Collaborator Author

varkoly commented Jun 9, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants