Do not allow empty values to enter login.defs cfa model. bsc#1208492

yast · Feb 22, 2023 · 3a47235 · 3a47235
1 parent e0a2d13
commit 3a47235
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/modules/Security.rb b/src/modules/Security.rb
@@ -554,6 +554,11 @@ def write_to_locations
     # Write login.defs configuration
     def write_shadow_config
       SHADOW_ATTRS.each do |attr|
+        # bsc#1208492 shadow config uses login.defs attr formatting
+        # like <Key><space>*<Value>, so empty value is not supported
+        # and moreover can cause crash in login.defs lens
+        next if @Settings[attr].nil? || @Settings[attr].empty?
+
         shadow_config.public_send("#{attr.to_s.downcase}=", @Settings[attr])
       end
       encr = @Settings.fetch("PASSWD_ENCRYPTION", default_encrypt_method)