Do a lazy initialization of network and security settings #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
approved these changes
Oct 31, 2023
|
✔️ Internal Jenkins job #748 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The initialization of the TargetConfig creates an instance of the security_settings which reads the defaults for ssh, firewall and vnc from the skelcd even when it does not need this configuration at all causing problems when it is read to early during the workflow or when it is not needed as commented.
In the related bug, it adds the package firewalld because according to the skelcd it needs to be enabled even if in the profile it is disabled or removed.
Solution
Do a lazy initialization of the settings just when required.
Testing