Include LSB services bnc#846422 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 31, 2013 16:12
- use list-units as the base for displaying services - add services from list-unit-files if they are missing - use Service.Status for getting information about the missing services
| @@ -71,11 +71,14 @@ def save | |||
| success = ServicesManager.save | |||
| UI.CloseDialog | |||
| if !success | |||
| # FIXME if user select to continue the content of the popup is not discarded | |||
| # and new error messages will be displayed beneath the old ones | |||
There was a problem hiding this comment.
Any advise how to achieve this would be helpful.
There was a problem hiding this comment.
I don't see any reason why it should have this behaviour. Quick look at source code doesn't show anything obvious. We should debug it how it can happen.
added 2 commits
November 4, 2013 13:08
- simplify double reject
vmoravec
pushed a commit
that referenced
this pull request
Nov 4, 2013
Include LSB services bnc#846422
| success = ! Popup::ContinueCancel( | ||
| _("Writing the configuration have failed.\n" + | ||
| _("Writing of the configuration have failed.\n" + |
There was a problem hiding this comment.
Writing of the configuration means something like a configuration poem, writing is a noun.
On the other hand writing the configuration uses writing as doing something.
There was a problem hiding this comment.
Thanks for the notice, it sounded somehow weird to me for some reason.. I will revert it with the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSB services were ignored by services manager as they are not 'pure' systemd units. More details in bnc#846422