Skip to content

Commit

Permalink
Update from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
dgdavid committed Aug 10, 2018
1 parent 55a376a commit 4f23f54
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions src/modules/Squid.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1448,21 +1448,21 @@ def Write
if !writeAllSettings
Report.Error(_("Cannot write settings."))

result &= false
result = false
end

# write firewall settings
Progress.NextStage
if !writeFirewallSettings
Report.Error(_("Cannot write firewall settings."))

result &= false
result = false
end

# save service status
Progress.NextStage
result &= save_status
result &= start_service
result = false unless save_status
result = false unless start_service

return false if Abort()

Expand Down
4 changes: 2 additions & 2 deletions testsuite/tests/squid_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
end

it "returns true" do
expect(squid.Write).to be_truthy
expect(squid.Write).to eq(true)
end
end

Expand All @@ -133,7 +133,7 @@
end

it "returns false" do
expect(squid.Write).to be_falsey
expect(squid.Write).to eq(false)
end
end
end
Expand Down

0 comments on commit 4f23f54

Please sign in to comment.