Skip to content

Commit

Permalink
Several improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
joseivanlopez committed Dec 5, 2019
1 parent ea947e7 commit 0727e03
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/lib/y2storage/disk_analyzer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def linux_systems(*disks)

# All fstabs found in the system
#
# Note that all filesystems are considered here, including filesystems over LVM LVs, see
# Note that all Linux filesystems are considered here, including filesystems over LVM LVs, see
# {#all_linux_suitable_filesystems}.
#
# @return [Array<Fstab>]
Expand All @@ -116,7 +116,7 @@ def fstabs

# All crypttabs found in the system
#
# Note that all filesystems are considered here, including filesystems over LVM LVs, see
# Note that all Linux filesystems are considered here, including filesystems over LVM LVs, see
# {#all_linux_suitable_filesystems}.
#
# @return [Array<Crypttab>]
Expand Down
9 changes: 6 additions & 3 deletions src/lib/y2storage/filesystem_reader.rb
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ def crypttab
crypttab: nil
}.freeze

private_constant :FS_ATTRIBUTES

# Filesystem attributes
#
# @return [Hash<Symbol, Object>]
Expand Down Expand Up @@ -216,14 +218,14 @@ def check_rpi_boot

# Mounts the filesystem
#
# @see execute
# @see #execute
#
# @note libstorage-ng has a couple of ways for immediate mounting/unmounting devices, but
# they cannot be easily used here.
#
# For example, BlkFilesystem::detect_content_info uses an internal EnsureMounted object.
# EnsureMounted mounts a given filesystem during its construction and unmounts it during
# its destuction. In ruby there is no a clear way of calling the destructor of a binding
# its destruction. In ruby there is no a clear way of calling the destructor of a binding
# object, so EnsureMounted cannot be used for a temporary mount to inspect the filesystem
# content from YaST and then unmount it.
#
Expand All @@ -247,7 +249,8 @@ def mount

# Unmounts the filesystem
#
# @see mount
# @see #mount
# @see #execute
#
# @raise [RuntimeError] when the filesystem cannot be unmounted
def umount
Expand Down

0 comments on commit 0727e03

Please sign in to comment.