Skip to content

Commit

Permalink
Improve wording
Browse files Browse the repository at this point in the history
  • Loading branch information
joseivanlopez committed Jan 15, 2018
1 parent 315839d commit 47ac233
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/lib/y2storage/boot_requirements_strategies/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def missing_partition_for?(volume)
# @return [SetupError]
def unknown_boot_disk_error
# TRANSLATORS: error message
error_message = _("Unknwon boot disk")
error_message = _("Boot requirements cannot be determined because there is no '/' mount point")
SetupError.new(message: error_message)
end
end
Expand Down
5 changes: 4 additions & 1 deletion src/lib/y2storage/boot_requirements_strategies/zipl.rb
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ def zipl_partition(target)
# @return [SetupError]
def unsupported_boot_disk_error
# TRANSLATORS: error message
error_message = _("Current boot disk cannot be used for booting")
error_message = _(
"Looks like the system is going to be installed on a FBA " \
"or LDL device. Booting from such device is not supported"
)
SetupError.new(message: error_message)
end
end
Expand Down
2 changes: 1 addition & 1 deletion test/y2partitioner/setup_errors_presenter_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
let(:product_errors) { [] }

it "contains a general error message for boot errors" do
expect(subject.to_html).to match(/could not load/)
expect(subject.to_html).to match(/not be able to boot/)
end

it "does not contain a general error message for product errors" do
Expand Down
4 changes: 2 additions & 2 deletions test/y2storage/boot_requirements_errors_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
expect(checker.errors).to all(be_a(Y2Storage::SetupError))

message = checker.errors.first.message
expect(message).to match(/boot disk/)
expect(message).to match(/there is no '\/'/)
end
end

Expand All @@ -100,7 +100,7 @@
expect(checker.errors).to all(be_a(Y2Storage::SetupError))

message = checker.errors.first.message
expect(message).to match(/cannot be used/)
expect(message).to match(/is not supported/)
end
end

Expand Down

0 comments on commit 47ac233

Please sign in to comment.