Merge pull request #396 from joseivanlopez/partitioner_multipath

Partitioner multipath fixes

doc/user-stories/expert-partitioner.md

@@ -652,6 +652,9 @@ The specs are based on current version of expert partitioner for TW. The goal is
       * shows dialog to edit the current selected LV in the table
       * same dialog than partition edition (see above)
       * 'File System Id' is not shown
+      * *(pending) and selected LV is a thin pool*
+        * shows an error popup
+        * does not allow to edit the LV
     * *(pending) and action 'Resize' is selected*
       * shows popup dialog to resize the current selected LV in the table
     * *(pending) and action 'Delete' is selected*

package/yast2-storage-ng.changes

@@ -1,3 +1,11 @@
+-------------------------------------------------------------------
+Wed Oct 25 17:28:48 UTC 2017 - jlopez@suse.com
+
+- Partitioner: allow to work with multipath devices.
+- bsc#1058373 and bsc#1028853.
+- Part of fate#318196.
+- 4.0.12
+
 -------------------------------------------------------------------
 Wed Oct 25 13:12:37 UTC 2017 - igonzalezsosa@suse.com
 

package/yast2-storage-ng.spec

@@ -16,7 +16,7 @@
 #
 
 Name:		yast2-storage-ng
-Version:        4.0.11
+Version:        4.0.12
 Release:	0
 BuildArch:	noarch
 

src/clients/inst_prepdisk.rb

@@ -1,4 +1,3 @@
-#!/usr/bin/env ruby
 # encoding: utf-8
 
 # Copyright (c) [2016] SUSE LLC

src/lib/y2partitioner/sequences/add_md.rb

@@ -2,7 +2,8 @@
 require "y2partitioner/sequences/transaction_wizard"
 require "y2partitioner/sequences/new_blk_device"
 require "y2partitioner/sequences/controllers"
-require "y2partitioner/dialogs"
+require "y2partitioner/dialogs/md"
+require "y2partitioner/dialogs/md_options"
 
 module Y2Partitioner
   module Sequences

src/lib/y2partitioner/sequences/add_partition.rb

@@ -1,3 +1,24 @@
+# encoding: utf-8
+
+# Copyright (c) [2017] SUSE LLC
+#
+# All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of version 2 of the GNU General Public License as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, contact SUSE LLC.
+#
+# To contact SUSE LLC about this file by physical or electronic mail, you may
+# find current contact information at www.suse.com.
+
 require "yast"
 require "y2partitioner/sequences/transaction_wizard"
 require "y2partitioner/sequences/new_blk_device"
@@ -12,8 +33,9 @@ class AddPartition < TransactionWizard
 
       # @param disk_name [String]
       def initialize(disk_name)
-        super()
+        textdomain "storage"
 
+        super()
         @part_controller = Controllers::Partition.new(disk_name)
       end
 

src/lib/y2partitioner/sequences/controllers/partition.rb

@@ -66,10 +66,10 @@ def initialize(disk_name)
         end
 
         # Device being partitioned
-        # @return [Y2Storage::Disk]
+        # @return [Y2Storage::BlkDevice]
         def disk
           dg = DeviceGraphs.instance.current
-          Y2Storage::Disk.find_by_name(dg, disk_name)
+          Y2Storage::BlkDevice.find_by_name(dg, disk_name)
         end
 
         # Available slots to create the partition

src/lib/y2partitioner/sequences/edit_blk_device.rb

@@ -1,3 +1,24 @@
+# encoding: utf-8
+
+# Copyright (c) [2017] SUSE LLC
+#
+# All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of version 2 of the GNU General Public License as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, contact SUSE LLC.
+#
+# To contact SUSE LLC about this file by physical or electronic mail, you may
+# find current contact information at www.suse.com.
+
 require "yast"
 require "y2partitioner/sequences/transaction_wizard"
 require "y2partitioner/sequences/controllers"
@@ -11,6 +32,8 @@ module Sequences
     class EditBlkDevice < TransactionWizard
       # @param blk_device [Y2Storage::BlkDevice]
       def initialize(blk_device)
+        textdomain "storage"
+
         super()
         @blk_device = blk_device
         @fs_controller = Controllers::Filesystem.new(blk_device, title)

src/lib/y2partitioner/ui_state.rb

@@ -1,3 +1,24 @@
+# encoding: utf-8
+
+# Copyright (c) [2017] SUSE LLC
+#
+# All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of version 2 of the GNU General Public License as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, contact SUSE LLC.
+#
+# To contact SUSE LLC about this file by physical or electronic mail, you may
+# find current contact information at www.suse.com.
+
 require "y2partitioner/widgets/pages/md_raids"
 require "y2partitioner/widgets/pages/lvm"
 

src/lib/y2partitioner/widgets/add_lvm_button.rb

@@ -43,6 +43,7 @@ def initialize(table)
 
       # @macro seeAbstractWidget
       def label
+        # TRANSLATORS: button label to add a volume group or logical volume
         _("Add...")
       end
 

src/lib/y2partitioner/widgets/add_lvm_lv_button.rb

@@ -39,6 +39,7 @@ def initialize(vg)
 
       # @macro seeAbstractWidget
       def label
+        # TRANSLATORS: button label to add a logical volume
         _("Add...")
       end
 

src/lib/y2partitioner/widgets/btrfs_subvolumes_add_button.rb

@@ -1,3 +1,24 @@
+# encoding: utf-8
+
+# Copyright (c) [2017] SUSE LLC
+#
+# All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of version 2 of the GNU General Public License as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, contact SUSE LLC.
+#
+# To contact SUSE LLC about this file by physical or electronic mail, you may
+# find current contact information at www.suse.com.
+
 require "yast"
 require "cwm"
 require "y2partitioner/device_graphs"
@@ -17,7 +38,9 @@ def initialize(table)
         @table = table
       end
 
+      # @macro seeAbstractWidget
       def label
+        # TRANSLATORS: button label to add a btrfs subvolume
         _("Add...")
       end
 

src/lib/y2partitioner/widgets/btrfs_subvolumes_delete_button.rb

@@ -1,3 +1,24 @@
+# encoding: utf-8
+
+# Copyright (c) [2017] SUSE LLC
+#
+# All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of version 2 of the GNU General Public License as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, contact SUSE LLC.
+#
+# To contact SUSE LLC about this file by physical or electronic mail, you may
+# find current contact information at www.suse.com.
+
 require "yast"
 require "cwm"
 require "y2partitioner/widgets/btrfs_subvolumes_table"
@@ -19,7 +40,9 @@ def initialize(table)
       end
 
       # Widget label
+      # @macro seeAbstractWidget
       def label
+        # TRANSLATORS: button label to delete a btrfs subvolume
         _("Delete...")
       end
 

src/lib/y2partitioner/widgets/configurable_blk_devices_table.rb

@@ -1,8 +1,28 @@
+# encoding: utf-8
+
+# Copyright (c) [2017] SUSE LLC
+#
+# All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of version 2 of the GNU General Public License as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, contact SUSE LLC.
+#
+# To contact SUSE LLC about this file by physical or electronic mail, you may
+# find current contact information at www.suse.com.
+
 require "yast"
 require "cwm/table"
 
 require "y2partitioner/device_graphs"
-require "y2partitioner/ui_state"
 require "y2partitioner/widgets/blk_devices_table"
 
 module Y2Partitioner
@@ -33,10 +53,19 @@ def init
         self.value = row_id(initial_sid) if initial_sid
       end
 
+      # Jumps to the page associated to the selected device
+      #
+      # @note Event is launched after double clicking over a row.
+      #
       # @macro seeAbstractWidget
       def handle
-        id = value[/table:(.*)/, 1]
-        @pager.handle("ID" => id)
+        device = selected_device
+        return nil if device.nil?
+
+        page = pager.device_page(device)
+        return nil if page.nil?
+
+        pager.handle("ID" => page.widget_id)
       end
 
       # Device object selected in the table