reduce complexity of DiskAnalyzer::analyze for rubocop

yast · Apr 20, 2016 · e48a57b · e48a57b
1 parent 6dee605
commit e48a57b
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/src/lib/storage/disk_analyzer.rb b/src/lib/storage/disk_analyzer.rb
@@ -163,15 +163,7 @@ def analyze(devicegraph)
           log.info("Linux partitions found - not checking for Windows partitions")
         end
 
-        log.info("Installation disks: #{@installation_disks}")
-        log.info("Candidate    disks: #{@candidate_disks}")
-        log.info("Linux   partitions: #{@linux_partitions}")
-        log.info("Windows partitions: #{@windows_partitions}")
-        log.info("EFI     partitions: #{@efi_partitions}")
-        log.info("PReP    partitions: #{@prep_partitions}")
-        log.info("GRUB    partitions: #{@grub_partitions}")
-        log.info("Swap    partitions: #{@swap_partitions}")
-        log.info("MBR gap: #{@mbr_gap}")
+        log_vars
       end
 
       # Look up devicegraph element by device name.
@@ -185,6 +177,19 @@ def device_by_name(name)
 
       attr_reader :devicegraph
 
+      # log internal state
+      def log_vars
+        log.info("Installation disks: #{@installation_disks}")
+        log.info("Candidate    disks: #{@candidate_disks}")
+        log.info("Linux   partitions: #{@linux_partitions}")
+        log.info("Windows partitions: #{@windows_partitions}")
+        log.info("EFI     partitions: #{@efi_partitions}")
+        log.info("PReP    partitions: #{@prep_partitions}")
+        log.info("GRUB    partitions: #{@grub_partitions}")
+        log.info("Swap    partitions: #{@swap_partitions}")
+        log.info("MBR gap: #{@mbr_gap}")
+      end
+
       # Find disks that look like the current installation medium
       # (the medium we just booted from to start the installation).
       #