Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: honor root_device also when is a software RAID (bsc#1161331) #1046

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Feb 18, 2020

Problem

In order to support S130/S140/S150 controllers (and also to be more compatible with the old storage), when a software RAID is completely empty (not formatted and not partitioned), it will be considered as a candidate device for the storage proposal.

As proven by #1043, in SLE-15-SP1 that resulted in a proposal that locates the /boot/efi partition inside the software RAID. Although that can be a bit controversial, Dell was happy with this behavior (their S130/S140/S150 controllers has indeed proven to be able to boot the resulting setup) and nobody has complained.

But in TW and in the beta versions of SLE-15-SP2, the proposal tries to locate the /boot/efi partitions directly in one of the physical disks and that leaded to an infinite loop.

Solution

This pull request:

This pull request does NOT include a fix for the infinite loop. The loop cannot longer be triggered in normal circumstances, but there is still a chance for it to reappear in the future. That will be addressed in a separate pull request with much lower priority.

Testing

Merged the mentioned unit test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.634% when pulling b978817 on ancorgs:bug_1161331 into 1f0b7ba on yast:master.

@ancorgs ancorgs requested a review from dgdavid February 18, 2020 12:33
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ancorgs ancorgs merged commit 1e6edfb into yast:master Feb 18, 2020
@yast-bot
Copy link

✔️ Public Jenkins job #266 successfully finished
✔️ Created OBS submit request #775172

@yast-bot
Copy link

✔️ Internal Jenkins job #90 successfully finished
✔️ Created IBS submit request #211590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants