Proposal: honor root_device also when is a software RAID (bsc#1161331) #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to support S130/S140/S150 controllers (and also to be more compatible with the old storage), when a software RAID is completely empty (not formatted and not partitioned), it will be considered as a candidate device for the storage proposal.
As proven by #1043, in SLE-15-SP1 that resulted in a proposal that locates the
/boot/efi
partition inside the software RAID. Although that can be a bit controversial, Dell was happy with this behavior (their S130/S140/S150 controllers has indeed proven to be able to boot the resulting setup) and nobody has complained.But in TW and in the beta versions of SLE-15-SP2, the proposal tries to locate the
/boot/efi
partitions directly in one of the physical disks and that leaded to an infinite loop.Solution
This pull request:
This pull request does NOT include a fix for the infinite loop. The loop cannot longer be triggered in normal circumstances, but there is still a chance for it to reappear in the future. That will be addressed in a separate pull request with much lower priority.
Testing
Merged the mentioned unit test.