Simplify the button sets #1127
Closed
Simplify the button sets #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of being a DeviceMenuButton grouping multiple actions, from now on it is just a DeviceButton to trigger the modify action for the selected device.
To simplify the DeviceButtonsSet using a simple DeviceButton for directly add a partition instead of a DeviceMenuButton grouping several partitions actions.
To simplify the DeviceButtonsSet using a simple DeviceButton for directly modify the device instead of a DeviceMenuButton grouping several related actions. Related to improvements discussed in https://lists.opensuse.org/yast-devel/2020-09/msg00004.html
To simplify the DeviceButtonsSet using a simple DeviceButton for directly modify the device instead of a DeviceMenuButton grouping several related actions. Related to improvements discussed in https://lists.opensuse.org/yast-devel/2020-09/msg00004.html
To simplify the DeviceButtonsSet when an LVM volume group is selected, according to the improvements discussed in https://lists.opensuse.org/yast-devel/2020-09/msg00004.html
To simplify the DeviceButtonsSet using a simple DeviceButton for directly adding an LVM LV instead of a DeviceMenuButton grouping several LVM VG related actions. Related to improvements discussed in https://lists.opensuse.org/yast-devel/2020-09/msg00004.html
Instead of being a DeviceMenuButton grouping multiple actions, it is now a DeviceButton to trigger the modify action for the selected LVM logical volume. Related to improvements discussed in https://lists.opensuse.org/yast-devel/2020-09/msg00004.html
Instead of being a DeviceMenuButton grouping multiple actions, it is now a DeviceButton to trigger the modify action for the selected Btrfs device. Related to improvements discussed in https://lists.opensuse.org/yast-devel/2020-09/msg00004.html
Instead of being a DeviceMenuButton grouping multiple actions, it is now a DeviceButton to trigger the modify action for selected partition. Related to improvements discussed in https://lists.opensuse.org/yast-devel/2020-09/msg00004.html
Replacing the partition menu-button by the button to create a new partition table, according to improvements discussed in https://lists.opensuse.org/yast-devel/2020-09/msg00004.html
Because they are no longer needed after latest UI changes to start using a menu bar. To know more, visit * #1125, and * https://lists.opensuse.org/yast-devel/2020-09/msg00004.html
dgdavid
force-pushed
the
simplify-button-sets
branch
from
f0fbcda
to
5e84fb5
Compare
Not calling neither, MainMenuBar#select_row nor MainMenuBar#select_page, when the main menu bar is not ready yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Short description of the original problem.
Solution
Short description of the fix.
Testing
Screenshots
If the fix affects the UI attach some screenshots here.