Partitioner: add menu actions #1142
Conversation
joseivanlopez
force-pushed
the
device_menu_actions
branch
from
f3c4775
to
9d5d5c2
Compare
joseivanlopez
force-pushed
the
device_menu_actions
branch
from
9d5d5c2
to
c4d62c0
Compare
joseivanlopez
changed the title
| end | ||
|
|
||
| private | ||
|
|
||
| # @see Base | ||
| # rubocop:disable Metrics/CyclomaticComplexity | ||
| # Is this a complex method actually? |
There was a problem hiding this comment.
Well, it likely could be substituted by a hash and/or a little bit of metaprogramming (generating the name of the method and then using send).
There was a problem hiding this comment.
Yes, sure. In fact, I did it with metaprogramming, but the result is more difficult to read/understand. In this kind of things, I am not able to understand why a simple case has high complexity.
There was a problem hiding this comment.
Well, if you tried and it looked worse, then I guess this is fine. I didn't actually tried, I was just assuming it could look good. But experience beats assumptions. :-)
There was a problem hiding this comment.
well, in general case is usually hidden class separation. Here it is done for actions. So if all actions has simple format of class.new or class.new(device). you can use something like MENU_ADD_MAPPING[event].new(device) So hash based factory.
There was a problem hiding this comment.
and btw if item is proper object, code can look like items.find { |i| i.id == event }.action and also above it can create list of items from object like @items ||= [add_md.item, add_vg.item, ..]
| @@ -75,12 +81,34 @@ def disabled_for_device | |||
| end | |||
|
|
|||
| # @see Base | |||
| # rubocop:disable Metrics/CyclomaticComplexity | |||
| # Is this a complex method actually? | |||
There was a problem hiding this comment.
Like before, this could be probably improved with a bit of send or similar.
This is part of the on-going process to reorganize the Partitioner UI into the branch partitioner-ui-02.
This PR makes the Device and Add menus completely functional by calling the proper action for every item of the menus.