Adapted to new OBS location #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| conf.obs_project = "home:aschnell:storage-redesign" | ||
| conf.obs_project = "YaST:storage-ng" | ||
| # Non-existent project to prevent accidental submission to Tumbleweed | ||
| conf.obs_sr_project = "NONE" |
There was a problem hiding this comment.
Um, why not nil? It does not work?
There was a problem hiding this comment.
Our tasks are not prepared to skip the request in case of nil. In the best case, setting it to nil is equivalent to setting it to the default value (i.e. Factory). In the worst case is equivalent to setting it to the empty string... thus invalid osc commands.
There was a problem hiding this comment.
Well, not sure which case is worst or better actually 😉 But none of them are desirable.
There was a problem hiding this comment.
I see, I thought nil could mean none, but it's the default...
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aschnell maybe it would be a good idea to delete
home:aschnell:storage-redesignto avoid future confusion.