-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added YaST Console checkbox for enabling LUKS2 support #1260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2f98e28
to
62ffe3a
Compare
5158e5f
to
11367d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, but now version and changelog are in conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
✔️ Internal Jenkins job #209 successfully finished |
✔️ Public Jenkins job #417 successfully finished |
Problem
Activating the experimental LUKS2 support added in #1245 is quite tricky:
YAST_LUKS2_AVAILABLE
variable nameSolution
Add an checkbox in the YaST expert console, that makes the setting easily accessible and it can be changed even during installation.
This is a perfect use case why I introduced the YaST expert console.
Testing
Ctrl+Alt+Shift+C
(in Qt) orCtrl+D Shift+C
(in ncurses) keyboard shortcut to activate the expert consoleScreenshots
Console Option
How it Works
Notes
When we add some more options in the future we could add
[Configure Partitioner]
button and group the partitioner options in a separate subdialog like the network settings.