Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added YaST Console checkbox for enabling LUKS2 support #1260

Merged
merged 5 commits into from
Jan 3, 2022
Merged

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Dec 6, 2021

Problem

Activating the experimental LUKS2 support added in #1245 is quite tricky:

  • You need to remember the quite long YAST_LUKS2_AVAILABLE variable name
  • If you forget to set it before starting YaST then you have to reboot the installation and start again 🤔
  • Once set you cannot change it later

Solution

Add an checkbox in the YaST expert console, that makes the setting easily accessible and it can be changed even during installation.

This is a perfect use case why I introduced the YaST expert console.

Testing

  • Tested manually
  • Use the Ctrl+Alt+Shift+C (in Qt) or Ctrl+D Shift+C (in ncurses) keyboard shortcut to activate the expert console

Screenshots

Console Option

luks2

How it Works

  • First show the default encryption options
  • Then activate the YaST expert console and enable LUKS2
  • Show the encryption options again, now with the LUKS2 option available

luks2

Notes

When we add some more options in the future we could add [Configure Partitioner] button and group the partitioner options in a separate subdialog like the network settings.

@coveralls
Copy link

coveralls commented Dec 6, 2021

Coverage Status

Coverage increased (+0.003%) to 97.738% when pulling 7f80a9f on luks2_config into 2b18bf4 on master.

Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak changed the title [PoC] [WIP] Added YaST Console checkbox for enabling LUKS2 support Added YaST Console checkbox for enabling LUKS2 support Dec 22, 2021
@lslezak lslezak marked this pull request as ready for review December 22, 2021 17:38
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, but now version and changelog are in conflict.

Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lslezak lslezak merged commit 78da30f into master Jan 3, 2022
@lslezak lslezak deleted the luks2_config branch January 3, 2022 10:33
@yast-bot
Copy link

yast-bot commented Jan 3, 2022

✔️ Internal Jenkins job #209 successfully finished
✔️ Created IBS submit request #261396

@yast-bot
Copy link

yast-bot commented Jan 3, 2022

✔️ Public Jenkins job #417 successfully finished
✔️ Created OBS submit request #943568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants