Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RSpec verifying doubles #1279

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Enable RSpec verifying doubles #1279

merged 2 commits into from
Jan 19, 2022

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jan 19, 2022 •
edited by joseivanlopez
Loading

Problem

  • RSpec verifying doubles are not enabled in the tests
  • That can hide some possible problems

Solution

  • Enable verifying doubles in test/spec_helper.rb
  • Fix reported issues
  • Additionally fixed missing mock for reading the NFS configuration. Originally it read the real configuration from the system including the firewalld configuration which displays a PolicyKit popup asking for the root password on my system.
  • See Added yast/rspec/helpers.rb (related to bsc#1194784) yast-ruby-bindings#281 for the new mocking helper

TODO

  • Fix the remaining test failures, these need a real storage expert 😃

Testing

  • Updated unit tests

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.759% when pulling 5f4036a on verifying_doubles into e2db182 on master.

@lslezak lslezak marked this pull request as ready for review January 19, 2022 13:11
@lslezak lslezak merged commit fc681ec into master Jan 19, 2022
@lslezak lslezak deleted the verifying_doubles branch January 19, 2022 14:48
@yast-bot
Copy link

✔️ Public Jenkins job #423 successfully finished

@yast-bot
Copy link

✔️ Internal Jenkins job #215 successfully finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidner mvidner mvidner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lslezak @coveralls @yast-bot @mvidner @joseivanlopez