New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Y2NfsClient::Widgets::NfsForm
instead of NfsClient4Part
#1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorgs
changed the title
Use the
Use Feb 2, 2022
Y2NfsClient::Widgets::NfsForm
instead of NfsClient4Part
Y2NfsClient::Widgets::NfsForm
instead of NfsClient4Part
Co-authored-by: José Iván López González <jlopez@suse.com>
Co-authored-by: José Iván López González <jlopez@suse.com>
Co-authored-by: José Iván López González <jlopez@suse.com>
Co-authored-by: José Iván López González <jlopez@suse.com>
joseivanlopez
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✔️ Public Jenkins job #426 successfully finished |
✔️ Internal Jenkins job #219 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This pull request replaces #1282 (same content but with clear history)
Traditionally, the management of NFS shares in the YaST Partitioner has been a bit rough. The Partitioner never really provided its own UI to add/edit/delete NFS mounts. Instead, it executed an embedded version of
yast2-nfs-client
. That has always been problematic. For example, there were non-obvious problems when the same NFS share was mounted more than once in the current system in two different locations (admittedly a very uncommon scenario).But the situation became much worse with the revamp of the interface done for SLE-15-SP3 (and openSUSE Leap 15.3). Since that moment, NFS management was completely inconsistent with the rest of the Partitioner interface:
Solution
This pull request goes together with yast/yast-nfs-client#105
With this pull request and the corresponding yast-nfs-client one mentioned above, the integration between both YaST modules is done in a more sensible way. All the functionality is still available, but in a way in which the integration is completely transparent offering a consistent user experience.
Testing