Ruby 3.2 yast2-storage-ng sometimes fails to build, diff in Marshal.dump #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Today's findings: The My plan is to accept the reality of the nondeterministic ordering and instead remove the gorilla from the room: WIP: irb(main):001:0> class C; def initialize(attrs); attrs.each { |a| instance_variable_set(a.to_sym, a.to_s) } ; end ; end
=> :initialize
irb(main):004:0> a = C.new([])
=> #<C:0x0000563aa62d27b0>
irb(main):005:0> b = C.new([])
=> #<C:0x0000563aa618b848>
irb(main):006:0> a == b
=> false
irb(main):007:0> module EqualByIVs; def ==(other); return if other.class != self.class; instance_variables.all? { |iv| instance_variable_get(iv) == other.instance_variable_get(iv) }; end; end
=> :==
irb(main):008:0> class C; include EqualByIVs; end
=> C
irb(main):009:0> a == b
=> true |
A word-diff is useful: git diff --color-words /var/tmp/build-root-standard/tmp/dump[12]
… values" This reverts commit 21b4a13. The debug print revealed that there is sometimes a different ordering of instance variables in VolumeSpecification than the one used by initialize/apply_defaults Don't know why, just live with it now
mvidner
force-pushed
the
ruby32-proposal-settings-comparison
branch
from
ad50a9b
to
984e54b
Compare
mvidner
force-pushed
the
ruby32-proposal-settings-comparison
branch
from
984e54b
to
90387ef
Compare
It started to matter once we defined SubvolSpecification#==
mvidner
force-pushed
the
ruby32-proposal-settings-comparison
branch
from
90387ef
to
2ebbab7
Compare
mvidner
force-pushed
the
ruby32-proposal-settings-comparison
branch
from
2ebbab7
to
567058c
Compare
jreidinger
reviewed
Mar 3, 2023
| # specify the instance variables used for the comparison: | ||
| # https://github.com/yast/yast-yast2/blob/master/library/general/src/lib/yast2/equatable.rb | ||
| module EqualByInstanceVariables | ||
| # TODO: move to base library? |
jreidinger
approved these changes
Mar 3, 2023
|
✔️ Public Jenkins job #452 successfully finished |
|
✔️ Internal Jenkins job #1138 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ruby 3.2 yast2-storage-ng sometimes fails to build, diff in Marshal.dump
The failing test means to check that a new
ProposalSettingsis in fact equal to the original one, and does so by dumping and reloading the two objects withMarshal. It fails in case the two objects differ in the order in which their instance variables were assigned.Solution
Instead of using
Marshal, addProposalSettings#==.Do it by introducing a simple module,
EqualByInstanceVariables, including it in that class and a couple of others that are used by it.Gory details: everything I've learned about equality in Ruby along the way, very messy so far: https://gist.github.com/mvidner/eb10bf4d70f0df5c1073a2229fd4491e
Testing
Screenshots
N/A