Add commit callbacks to inst_prepdisk #1336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Agama uses the inst_prepdisk client to perform the required storage actions. That client calls to the storage commit action, which uses the default commit callbacks from YaST to report the errors.
Agama needs to provide its own callbacks, see openSUSE/agama#558.
Solution
Allows to pass commit callbacks to the inst_prepdisk client.