Ensure adding Storage Support Software Packages for MicroOS [SLE-15-SP5] #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://msp-greg.github.io/rubocop/RuboCop/Cop/Lint/SafeNavigationWithEmpty.html says my code "will actually do the opposite of what the author intends" which is not true in this case (as proven by the unit tests).
Honor proposal encryption from ProductFeatures
Ensure adding Storage Support Software Packages for MicroOS [SLE-15-SP4]
joseivanlopez
approved these changes
Jul 11, 2023
|
✔️ Internal Jenkins job #755 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Branch / Product
This is the merge to SLE-15-SP5 of #1346 .
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1212452
Trello
https://trello.com/c/T9nqET80/
Problem
On an system with a multipath storage setup, the reboot after the installation failed. It turned out that the multipath-tools package was not installed.
Cause
A regular SLE-15-SPx or Leap 15.x or Tumbleweed installation uses the inst_disk_proposal client in the installation workflow which at its end determines which storage features (e.g. Btrfs, XFS, LVM, multipath) are used and adds the software packages that are needed for those technologies to the pool of packages that are going to be installed.
But MicroOS has a different installation workflow, and it doesn't use that default inst_disk_proposal client at all; instead, it uses a custom partitions_proposal client to handle the storage proposal. And in that client, the packages handling was missing.
Fix
Added the packages handling to that partitions_proposal client.
To avoid code duplication, that handling was factored out from the inst_disk_proposal client: It is now done by a new
PackageHandler::set_proposal_packages_for(devicegraph)method which is now called from both clients.Test
New unit tests for that new method and for fringe cases
Manual test in a Leap 15.5 VM with the changed files to test against regressions
Manual test in a MicroOS 5.3 VM to check if the support packages are added; changed the storage setup between the default Btrfs to a nonstandard XFS and observed the log file if the packages were added correctly.
Installer Self-Update / Maintenance Update
No self-update needed for SLE-15-SP5 / Leap 15.5
The change can wait for the next QU for SLE-15-SP5 / Leap 15.5
Related PRs