Fix unlimited-sized fake device graphs (bsc#1221222) [SLE-15-SP6 Backport] #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
approved these changes
Apr 4, 2024
|
✔️ Internal Jenkins job #8 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Branch
This is a backport of PR #1375 to SLE-15-SP6.
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1221222
Problem
Build failure of yast-storage-ng with the latest SWIG bindings.
Cause
The unit tests use
DiskSize::unlimitedin the YAML files for many test scenarios for LVs, and that results in a value -1 which clashes with the libstorage function prototype that expectsunsigned long longforcreate_lvm_lv().Obviously SWIG decides at runtime (!) which C++ function to call, and now the checks appear to be stricter: A -1 worked well until this version; it had obviously converted it to the bit pattern of the expected unsigned type, in this case resulting in 16 EiB - 1. Now that doesn't work anymore.
Fix
Don't use unlimited for LVM LVs in the YAML fake device graphs; that's unrealistic and not possible in real life anyway.
This fix is limited purely to unit test data. There is no code change.