Guided setup improvements #204
Conversation
| return @candidate_disks if @candidate_disks | ||
| candidates = settings.candidate_devices || [] | ||
| candidates = candidates.map { |d| analyzer.device_by_name(d) } | ||
| candidates = analyzer.candidate_disks if candidates.empty? |
There was a problem hiding this comment.
I am not sure if I get logic there. If settings is set, it will use it. And if settings is not set, it will return result of analyzer. So if you going back in guided setup and you previously pick only one disk, it will skip selecting disks, right?
There was a problem hiding this comment.
Yes, and that is wrong. I guess that it should always be considered as list of candidates (that is, the list of disks that could be selected) the result of the analyzer.
|
|
||
| def expect_not_run_select_disks | ||
| expect_not_run_dialog(Y2Storage::Dialogs::GuidedSetup::SelectDisks) | ||
| end |
There was a problem hiding this comment.
what is goal of this shorthand. Expect is usually used once for specific test. Allow which is there before make sense, as allow is often used in before handlers and so on. So how often is this expect used?
There was a problem hiding this comment.
Right now only once, but maybe in next iterations we will skip more steps of the wizard. In these cases, we will expect to skip the same dialog several times.
There was a problem hiding this comment.
well, I found this quite unusual. But it is probably just my taste so NP.
Add some improvements suggested by UX expert.
PBI: https://trello.com/c/crhdffWC/516-5-storageng-guided-setup