Fix use #411
Merged
Fix use #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| all << devicegraph.partitions.find { |p| device.reuse == p.name } | ||
| when Y2Storage::Planned::LvmVg | ||
| vg = devicegraph.lvm_vgs.find { |v| File.join("/dev", device.reuse) == v.name } | ||
| all.concat(vg.lvm_pvs.map(&:blk_device)) |
There was a problem hiding this comment.
Method LvmPv#blk_device could return the encryption device instead of the blk device. There is no problem if the device hosting the PV is a partition due to you are searching then by partitions in the ancestors list. But there is a possible corner case: a PV over an encrypted disk. Is it necessary to take into account that scenario? Probably not because you are only working with partitions here, isn't it?
There was a problem hiding this comment.
Thanks for the info. Yes, I am working with partitions. If I can reach the partition through the "#ancestors" method, it will be ok. If not, I guess I should handle it.
| Y2Storage::Planned::Partition.new("/").tap { |p| p.reuse = "/dev/sda1" } | ||
| end | ||
|
|
||
| it "does not removes the partition table" do |
There was a problem hiding this comment.
Typo: removes --> remove
* master: Bump version Improve Devicegraph#remove_md Fix text and doc Fix doc Update version and changelog Update specs Remove LvmResizeButton Add resize and delete buttons Add DeviceResizeButton Add support to delete button for deleting mds Add Actions::DeleteMd Add Devicegraph#remove_md Move methods to base class Actions::DeleteDevice
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an important bug: bsc#1066398.
Basically, AutoinstSpaceMaker kicks in when partitions have been planned and does not remove any partition that could be reused.
The tricky part is mapping the
sidwith thedevice namein order to reassignreuseproperties after making space (as, for instance, removing a logical partition might cause other partitions to be renamed).