Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storage checks #468

Merged
merged 21 commits into from Jan 16, 2018
Merged

Add storage checks #468

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d718825
Add support for matching volumes
joseivanlopez Jan 12, 2018
4ff3880
Add support for disk devices
joseivanlopez Jan 12, 2018
c124544
Add support for raids
joseivanlopez Jan 12, 2018
1e121ab
Fix analyzer
joseivanlopez Jan 12, 2018
7c55909
Add SetupError class
joseivanlopez Jan 12, 2018
4de0d87
Add support for boot errors
joseivanlopez Jan 12, 2018
712a787
Add class SetupChecker
joseivanlopez Jan 12, 2018
c8c2777
Add class SetupErrorsPresenter
joseivanlopez Jan 12, 2018
4a6f582
Validate partitioner setup
joseivanlopez Jan 12, 2018
87b8938
Fix doc
joseivanlopez Jan 15, 2018
1b9222d
Update version and changelog
joseivanlopez Jan 15, 2018
fb197cd
Add fixme
joseivanlopez Jan 15, 2018
26e3465
Remove align from planned partitions
joseivanlopez Jan 15, 2018
690ff06
Method #to_html always returns a string
joseivanlopez Jan 15, 2018
53f5af4
Several fixes
joseivanlopez Jan 15, 2018
6425d89
Allow more filesystems for zipl
joseivanlopez Jan 15, 2018
c7133b7
Improve wording
joseivanlopez Jan 15, 2018
645f734
Rename filesystem id to partition id
joseivanlopez Jan 15, 2018
f149102
Silly fixes
joseivanlopez Jan 15, 2018
d716a7e
Improve changelog and fix version number
joseivanlopez Jan 15, 2018
6f23a5e
Several fixes
joseivanlopez Jan 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/y2storage/boot_requirements_strategies/zipl.rb
View file
Open in desktop
Expand Up @@ -70,8 +70,8 @@ def zipl_volume

@zipl_volume = VolumeSpecification.new({})
@zipl_volume.mount_point = "/boot/zipl"
@zipl_volume.fs_types = [Filesystems::Type::EXT2]
@zipl_volume.fs_type = Filesystems::Type::EXT2
@zipl_volume.fs_types = Filesystems::Type.zipl_filesystems
@zipl_volume.fs_type = Filesystems::Type.zipl_filesystems.first
@zipl_volume.min_size = DiskSize.MiB(100)
@zipl_volume.desired_size = DiskSize.MiB(200)
@zipl_volume.max_size = DiskSize.GiB(1)
Expand Down
15 changes: 14 additions & 1 deletion src/lib/y2storage/filesystems/type.rb
View file
Open in desktop
Expand Up @@ -120,9 +120,11 @@ class Type

LEGACY_HOME_FILESYSTEMS = [:reiserfs]

ZIPL_FILESYSTEMS = [:ext2, :ext3, :ext4, :xfs]

private_constant :PROPERTIES, :ROOT_FILESYSTEMS, :HOME_FILESYSTEMS,
:COMMON_FSTAB_OPTIONS, :EXT_FSTAB_OPTIONS, :LEGACY_ROOT_FILESYSTEMS,
:LEGACY_HOME_FILESYSTEMS
:LEGACY_HOME_FILESYSTEMS, :ZIPL_FILESYSTEMS

# Allowed filesystems for root
#
Expand Down Expand Up @@ -152,6 +154,17 @@ def self.legacy_home_filesystems
LEGACY_HOME_FILESYSTEMS.map { |f| find(f) }
end

# Allowed filesystems for zipl boot partition
#
# @note See page 13 in following link
# https://share.confex.com/share/123/webprogram/Handout/\
# Session15694/SHARE_Bootloader_Ihno_PittsPPT_0.09.pdf
#
# @return [Array<Filesystems::Type>]
def self.zipl_filesystems
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be mentioned that the first one is the preferred one (i.e. used by the guided setup)

ZIPL_FILESYSTEMS.map { |f| find(f) }
end

# Check if filesystem is usable as root (mountpoint "/") filesystem.
#
# return [Boolean]
Expand Down