Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reasonable values for passno in fstab (bsc#1078703) #620

Merged
merged 4 commits into from
Apr 27, 2018

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Apr 26, 2018

Implements https://trello.com/c/yzueuWcq/256-1-propose-correct-better-mount-options-for

Manually tested for an ext4 installation (fs_passno correctly set to 1) and a Btrfs one (correctly set to 0)

@coveralls
Copy link

coveralls commented Apr 26, 2018

Coverage Status

Coverage increased (+0.003%) to 97.003% when pulling a402400 on ancorgs:passno into 0eae65d on yast:master.

@ancorgs ancorgs force-pushed the passno branch 5 times, most recently from 30f7612 to bc59fe9 Compare April 27, 2018 10:18
Is not used (it creates a useless MountPoint associated to nothing
in the devicegraph). It was simply added to the original wrapper with
no use case.
@ancorgs ancorgs force-pushed the passno branch 2 times, most recently from edaa1e0 to 97cedb3 Compare April 27, 2018 10:31
@ancorgs ancorgs changed the title Ensure reasonable values for passno and freq in fstab (bsc#1078703) Ensure reasonable values for passno in fstab (bsc#1078703) Apr 27, 2018
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ancorgs ancorgs merged commit 63bff53 into yast:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants