Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide windows actions if there are no windows partitions #716

Merged
merged 2 commits into from Aug 23, 2018

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Aug 22, 2018

No windows partition present

nowindowspartitions

Windows partition is present

withwindowspartitions

@coveralls
Copy link

coveralls commented Aug 22, 2018

Coverage Status

Coverage increased (+0.0004%) to 97.035% when pulling ac1da26 on hide_windows into e64427d on master.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a NP

@@ -16,7 +16,7 @@
#

Name: yast2-storage-ng
Version: 4.1.8
Version: 4.1.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: tab size is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and amended the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used rake version:bump. So spaces were used instead of a tab, it will happen always that version:bump is used

@teclator teclator merged commit 48812d3 into master Aug 23, 2018
@teclator teclator deleted the hide_windows branch August 23, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants