Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of temporary doc space_maker_improve_strategy.md #782

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Oct 25, 2018

@coveralls
Copy link

coveralls commented Oct 25, 2018

Coverage Status

Coverage remained the same at 97.198% when pulling 26e9628 on ancorgs:doc_maker into 05ad85f on yast:master.

@joseivanlopez
Copy link
Contributor

I like the idea of having a flexible way for defining select_next_action. This would give us quite a lot of room to adapt the algorithm to do "whatever" we want. The problem will be to find the priority between actions that most matches the user expectations. For example:

  • Should we take into account all candidate disks when deciding next action? Or disk by disk?
  • How to prioritize actions that leads to the same result, e.g., in this scenario [Linux][Free][Linux], and both Linux has the same size.

It is only a matter of deciding priorities, but I hope that priorities could be easily understandable for users.

@ancorgs
Copy link
Contributor Author

ancorgs commented Oct 26, 2018

As a first step, I would just duplicate the current logic to a big extend. So we would have a SpaceMaker that acts in the same way than the current one but allow us to start tuning it step by step.

Something like:

def select_next_action
  if linux_partitions.any?
    action_to_delete_the_end_linux_partition
  else
    if windows_partitions.any?(:not_resized_yet)
        action_to_resize_the_end_windows_partition
    else
        if other_partitions.any?
            action_to_delete_the_end_linux_partition
        ...
        end
    ...
    end
  ...
  end
end

The first step from there would be to introduce the exceptions requested in fate#325885 and fate#323484.

@ancorgs
Copy link
Contributor Author

ancorgs commented Oct 26, 2018

I will make that idea more obvious by adding the content of my comment to the document

@ancorgs ancorgs force-pushed the doc_maker branch 2 times, most recently from 5bd7f92 to f6d2594 Compare October 26, 2018 10:11
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yast-bot
Copy link

✔️ Public Jenkins job #53 successfully finished
✔️ Created OBS submit request #644828

@yast-bot
Copy link

✔️ Internal Jenkins job #62 successfully finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants