-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of temporary doc space_maker_improve_strategy.md #782
Conversation
I like the idea of having a flexible way for defining
It is only a matter of deciding priorities, but I hope that priorities could be easily understandable for users. |
As a first step, I would just duplicate the current logic to a big extend. So we would have a SpaceMaker that acts in the same way than the current one but allow us to start tuning it step by step. Something like: def select_next_action
if linux_partitions.any?
action_to_delete_the_end_linux_partition
else
if windows_partitions.any?(:not_resized_yet)
action_to_resize_the_end_windows_partition
else
if other_partitions.any?
action_to_delete_the_end_linux_partition
...
end
...
end
...
end
end The first step from there would be to introduce the exceptions requested in fate#325885 and fate#323484. |
I will make that idea more obvious by adding the content of my comment to the document |
5bd7f92
to
f6d2594
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✔️ Public Jenkins job #53 successfully finished |
✔️ Internal Jenkins job #62 successfully finished |
Bootstraping the discussion about https://trello.com/c/Xiai2Fpa/369-3-define-a-better-spacemaker-strategy-brainstorm