Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find crypttab names #790

Merged
merged 13 commits into from
Nov 7, 2018

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Oct 31, 2018

@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage increased (+0.006%) to 97.208% when pulling 7e91f6b on joseivanlopez:feature/find_crypttab_names into 4185cbe on yast:master.

@joseivanlopez joseivanlopez force-pushed the feature/find_crypttab_names branch 2 times, most recently from a0714fb to 2e79a7b Compare November 5, 2018 15:35
@joseivanlopez joseivanlopez changed the title [WIP] Find crypttab names Find crypttab names Nov 6, 2018
@joseivanlopez joseivanlopez force-pushed the feature/find_crypttab_names branch 3 times, most recently from f3e478b to 37e230a Compare November 6, 2018 16:31
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a few minor typos and a possible needed change.

src/lib/y2storage/devicegraph.rb Outdated Show resolved Hide resolved
src/lib/y2storage/devicegraph.rb Outdated Show resolved Hide resolved
src/lib/y2storage/encryption.rb Outdated Show resolved Hide resolved
src/lib/y2storage/encryption.rb Show resolved Hide resolved
src/lib/y2storage/encryption.rb Outdated Show resolved Hide resolved
doc/upgrade.md Outdated Show resolved Hide resolved
doc/upgrade.md Outdated Show resolved Hide resolved
doc/upgrade.md Outdated Show resolved Hide resolved
doc/upgrade.md Outdated Show resolved Hide resolved
doc/upgrade.md Outdated Show resolved Hide resolved
doc/upgrade.md Outdated Show resolved Hide resolved
src/lib/y2storage/luks.rb Outdated Show resolved Hide resolved
doc/upgrade.md Outdated Show resolved Hide resolved
doc/upgrade.md Outdated Show resolved Hide resolved
doc/upgrade.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of errors in upgrade.md. But I'm approving anyways. Feel free to merge after removing the surplus paragraph and the "realated" changes. 😉

@joseivanlopez joseivanlopez merged commit f81989a into yast:master Nov 7, 2018
@yast-bot
Copy link

yast-bot commented Nov 7, 2018

✔️ Internal Jenkins job #72 successfully finished
✔️ Created IBS submit request #176943

@yast-bot
Copy link

yast-bot commented Nov 8, 2018

✔️ Public Jenkins job #64 successfully finished
✔️ Created OBS submit request #647110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants