Allow to create bcache without caching set #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
changed the title
- Includes some clean up
- Includes some clean up
joseivanlopez
force-pushed
the
bcache_without_cset
branch
from
7861309
to
3d0f583
Compare
joseivanlopez
changed the title
ancorgs
reviewed
Feb 7, 2019
ancorgs
reviewed
Feb 7, 2019
ancorgs
reviewed
Feb 7, 2019
ancorgs
reviewed
Feb 7, 2019
ancorgs
reviewed
Feb 7, 2019
ancorgs
reviewed
Feb 7, 2019
ancorgs
reviewed
Feb 7, 2019
joseivanlopez
force-pushed
the
bcache_without_cset
branch
from
c37a4a1
to
1cf98ac
Compare
joseivanlopez
force-pushed
the
bcache_without_cset
branch
from
1cf98ac
to
84440ae
Compare
|
❌ Public Jenkins job #99 failed |
|
✔️ Internal Jenkins job #108 successfully finished |
|
❌ Public Jenkins job #101 failed |
|
✔️ Public Jenkins job #102 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bcache devices can be created without an associated caching set. In fact, this is a recommended practice if you are thinking about using bcache later. The idea is to setup all your slow devices as bcache backing devices without a cache, and you can choose to add a caching device later.
The Expert Partitioner needs to be adapted to allow bcache creation without a caching set.
Solution
The widget to select the caching set now has a new option: "Without caching".
Testing
Screenshots
Option to not select caching device
Error when there are no suitable backing devices
Added help