Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textdomain to fix untranslated error messages #925

Merged
merged 4 commits into from Nov 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions package/yast2-storage-ng.changes
@@ -1,3 +1,11 @@
-------------------------------------------------------------------
Wed Nov 11 14:44:26 UTC 2020 - Martin Vidner <mvidner@suse.com>

- Untranslated error message in 'Edit Btrfs subvolumes'/
'Add subvolume' (bsc#1130822)
- Detect missing textdomain during unit testing.
- 4.3.20

-------------------------------------------------------------------
Thu Nov 5 10:26:55 UTC 2020 - Stefan Hundhammer <shundhammer@suse.com>

Expand Down
2 changes: 1 addition & 1 deletion package/yast2-storage-ng.spec
Expand Up @@ -16,7 +16,7 @@
#

Name: yast2-storage-ng
Version: 4.3.19
Version: 4.3.20
Release: 0
Summary: YaST2 - Storage Configuration
License: GPL-2.0-only OR GPL-3.0-only
Expand Down
2 changes: 2 additions & 0 deletions src/lib/y2partitioner/dialogs/btrfs_subvolume.rb
Expand Up @@ -102,6 +102,7 @@ class SubvolumePath < CWM::InputField
# @param form [Dialogs::BtrfsSubvolume::Form]
# @param filesystem [Y2Storage::Filesystems::BlkFilesystem] a btrfs filesystem
def initialize(form, filesystem: nil)
textdomain "storage"
@form = form
@filesystem = filesystem
end
Expand Down Expand Up @@ -236,6 +237,7 @@ class SubvolumeNocow < CWM::CheckBox
# @param form [Dialogs::BtrfsSubvolume::Form]
# @param filesystem [Y2Storage::Filesystems::BlkFilesystem] a btrfs filesystem
def initialize(form, filesystem: nil)
textdomain "storage"
@form = form
@filesystem = filesystem
end
Expand Down
1 change: 1 addition & 0 deletions src/lib/y2partitioner/dialogs/import_mount_points.rb
Expand Up @@ -87,6 +87,7 @@ class FormatWidget < CWM::CheckBox
#
# @param controller [Actions::Controllers::Fstabs]
def initialize(controller)
textdomain "storage"
@controller = controller
end

Expand Down
2 changes: 2 additions & 0 deletions src/lib/y2partitioner/widgets/fstab_selector.rb
Expand Up @@ -191,6 +191,7 @@ class FstabContent < CWM::CustomWidget
#
# @param fstab [Y2Storage::Fstab]
def initialize(fstab)
textdomain "storage"
@fstab = fstab
end

Expand Down Expand Up @@ -235,6 +236,7 @@ class FstabTable < Widgets::BlkDevicesTable
#
# @param fstab [Y2Storage::Fstab]
def initialize(fstab)
textdomain "storage"
@fstab = fstab
end

Expand Down
2 changes: 2 additions & 0 deletions test/spec_helper.rb
Expand Up @@ -26,6 +26,8 @@
# make sure we run the tests in English locale
# (some tests check the output which is marked for translation)
ENV["LC_ALL"] = "en_US.UTF-8"
# fail fast if a class does not declare textdomain (bsc#1130822)
ENV["Y2STRICTTEXTDOMAIN"] = "1"

LIBS_TO_SKIP = ["y2packager/repository"]

Expand Down