Fix for bsc#991252 #220
Merged
Fix for bsc#991252 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug when proposal suggests to turn a EPS into bios_grub
|
LGTM |
|
Needs libstorage 2.26.6 for the testsuite. |
|
Test LGTM. Let's wait for OBS (libstorage) to re-run Travis. |
| # encoding: utf-8 | ||
|
|
||
| # testedfiles: helper.rb | ||
|
|
There was a problem hiding this comment.
@ancorgs I have just one comment here: bsc-991252 is a great reference, but as the history shows, we often fix something which was actually not reported, because the root of the issue was something else. So, it would make sense to put some comment/information into the actual test that describes the scenario and test-case itself in human-readable form and explains what is the test about.
I like the way you create these tests for bugs, that's a good idea. I'm just looking into the future - how to benefit from that even more. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when proposal suggests to turn a EPS into bios_grub