Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master current icons directory #101

Merged
merged 9 commits into from
Nov 7, 2018
Merged

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Nov 7, 2018

No description provided.

@schubi2 schubi2 merged commit 7b38c36 into master Nov 7, 2018
@schubi2 schubi2 deleted the master_current_icons_directory branch November 7, 2018 14:14
@yast-bot
Copy link
Contributor

yast-bot commented Nov 7, 2018

❌ Internal Jenkins job #10 failed

@yast-bot
Copy link
Contributor

yast-bot commented Nov 7, 2018

✔️ Public Jenkins job #9 successfully finished
✔️ Created OBS submit request #647016

@DimStar77
Copy link
Contributor

Just curious:

# ../current/icons is a directory in older versions of yast2-branding-openSUSE.
# While update via cpio this directory cannot be overwritten by a link with the same name. 

That makes sense, as old packages seem to have a directory, that needs to be cleaned up, so the cpio extractor can place the link.

but then, you have +if test -L %{yast_themedir}/current ; then which means you are going to rm the 'current' symlink if it is already a link. Effectlively most likely breaking all future updates of that package (rpm won't put the link back if it was not changed, but you just removed it) and still not fixing the upgrade issue from then /current was a directory.

Or am I reading this all backwards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants