Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLE-15-SP3] Add pattern-budgie icon (boo#1176164) #131

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

gmbr3
Copy link
Contributor

@gmbr3 gmbr3 commented Sep 5, 2020

This adds the logo for the upcoming Budgie pattern
The icon is licensed under CC-BY-SA 4.0 (not sure if this is ok, I can see other ones with CC-BY-SA 2.0 which is fine with CC-BY-SA 4.0 but the project license is GPL-2.0 which is incompatible with all CC-BY-SA versions. )

@gmbr3 gmbr3 marked this pull request as ready for review September 5, 2020 17:14
@jreidinger
Copy link
Member

@lnussel @DimStar77 Does anyone of you has idea about that license stuff? Otherwise having icon is fine for me, but I would like to avoid license collisions i branding.

@jreidinger
Copy link
Member

@lnussel @DimStar77 ping

@lnussel
Copy link
Contributor

lnussel commented Nov 13, 2020

Would have to ask legal for definitive answer. IMHO should be ok to adjust the spec file to include the extra license. Probably should list somewhere which icon is which license also.

@gmbr3
Copy link
Contributor Author

gmbr3 commented Jan 25, 2021

updated

@gmbr3
Copy link
Contributor Author

gmbr3 commented Feb 18, 2021

updated

@dgdavid
Copy link
Member

dgdavid commented Jul 28, 2021

@lnussel @DimStar77 @jreidinger friendly ping.

Does this look good after latest updates?

Thanks!

@dgdavid dgdavid changed the base branch from master to SLE-15-SP3 August 23, 2021 10:50
@dgdavid
Copy link
Member

dgdavid commented Aug 23, 2021

@gmbr3

I really sorry for the very big delay here 🤦‍♂️

To move it forward and not continue blocking it, I solved conflicts and edited the PR to make it against SLE-15-SP3 branch (former master). I'll take care to sync it later with master branch. Hope you don't mind.

Thanks you!

Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it was already approved by @DimStar77, I'm re-approving it myself after fixing conflicts and changing the target branch.

@dgdavid dgdavid merged commit a4103c0 into yast:SLE-15-SP3 Aug 23, 2021
@dgdavid dgdavid changed the title Add pattern-budgie icon (boo#1176164) [SLE-15-SP3] Add pattern-budgie icon (boo#1176164) Aug 23, 2021
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #3 successfully finished
✔️ Created IBS submit request #248701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants