Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install scalable icons & fix name of yast-yast-language.* to yast-language.* #45

Closed
wants to merge 2 commits into from

Conversation

DimStar77
Copy link
Contributor

gnome-shell very much prefers scalable icons (*.svg) for good results (sharp icons), and, as we already have them, let's install them.

the icon for language is referenced as yast-language in the .desktop file.. so either there it's wrong or the icon file names are wrong... one must change

@mvidner
Copy link
Member

mvidner commented Aug 13, 2014

Thanks! It looks OK, except I am not sure whether it is a good fit for SLES too. I'll check that tomorrow.

@mvidner
Copy link
Member

mvidner commented Aug 15, 2014

The "language" bit is problematic, it turns out there are two different designs,

  • an OSN flag
  • a pair of US/German flags

@DimStar77
Copy link
Contributor Author

Quoting Martin Vidner notifications@github.com:

The "language" bit is problematic, it turns out there are two
different designs,

  • an OSN flag
  • a pair of US/German flags

I see - In this case we have another underlying issue: not all PNGs do
have their .svg representation in git.. so it's impossible to actually
'correct' it the right way (you see it especially in gnome-shell,
where the 48x48 icon needs to be scaled up to 256x256 - and is blurry).

Can you verify if 'somebody' has the source svg files to those pngs?

Dominique

@mvidner
Copy link
Member

mvidner commented Aug 15, 2014

Can you verify if 'somebody' has the source svg files to those pngs?

I doubt it, but maybe @kwwii has it?

Sorry, it seems I will not have time for this today (a SLES snapshot) or the next week (vacation). Please catch someone else on the yast channel next week.

Mon Aug 11 16:10:06 UTC 2014 - dimstar@opensuse.org

- Install scalable icons in SVG format: gnome-shell prefers those
or will try to scale any of the found png files to 256x26,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little typo: 256x256

@jreidinger
Copy link
Member

@DimStar77 any update? I also do not see fix of typo

@coolo
Copy link
Contributor

coolo commented Aug 28, 2014

This becomes in parts obsolete by #47

@jreidinger
Copy link
Member

@DimStar77 what is status here? looks like part is already obsolete, what to do with rest?

@DimStar77
Copy link
Contributor Author

@jreidinger seems currenty reasonable on my install - but I don't have all modules of course... the goal should really be to get the corresponding .svg files installed as well - but not more to be done out of this pull req

@DimStar77 DimStar77 closed this Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants