appstream: install metainfo.xml file

[DimStar77]

Hope that is all right...

basing it off the .desktop file(s) looks much more complex and with little value, as only the Name/Summary is really there...

preferably, each .desktop file with it's metainfo.xml should be living in a sep. package (no collection of plugins, as enabling one in g-s will 'enable multiple' - and more confusing so on uninstalling a plugin)

If the .desktops happen to be split across multiple rpm, it get's more confusing, as the ID in the metainfo.xml has to refer to the package name the .desktop file lives in.

Hence, I believe that a manual import of this simplostic xml file would be more suitable

[mchf]

travis complains that:
src/Makefile.am:30: metainfo_DATA' is used butmetainfodir' is undefined

[DimStar77]

@mchf Thanks for the hint... fixed it

[mchf]

for me LGTM

[lslezak]

.org

[DimStar77]

Glad that you know my email address :) Will fix this of course (and finally buy a new keyboard.. my 'g' keeps on being missed

[lslezak]

I'm missing the reason for this change, any Bugzilla or FATE reference?

Do we need to adapt all other YaST modules? Which tools/desktops use this metadata, what's the visible benefit for the end user?

And I do not like repeating the name, summary, license, etc.. values one more time in a different file, I think these values should be generated from .spec file by a script at build time. Otherwise the data can easily get out of sync...

[DimStar77]

Reason for the change: Make yast available / accessible in GNOME Software (which is a 'software' centric install manager, as opposed to package centric; I can create a fate entry if this helps in any way.

The current state of affairs is:
Yast is listed as an application in GNOME Software (it contains an appdata.xml file) and all yast modules should be listed as 'addons' to yast (hence they get a metainfo.xml file)

[DimStar77]

Yast is currently presented like http://paste.opensuse.org/86381690 in gnome-software (no addons listed) - all available modules should preferably be presented as addons, to make them discoverable

[lslezak]

Please, create a FATE entry, we submit the master branch also to SLE12-SP1 which requires a FATE/BNC in the .changes file so we need something for a reference...

[DimStar77]

https://features.opensuse.org/319035

[lslezak]

I'm closing this PR, as written in #13 (comment) the metainfo.xml file should be automatically generated from the RPM spec file. We should not duplicate the data, it could easily get obsolete and become inconsistent with the spec file.

To the feature: thank you for adding it, but we are currently focused on important bug fixes for SLE12-SP1, so be patient...