Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scheduler activation (bsc#1052770) #27

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Aug 14, 2017

Do not activate the new scheduler for devices
which do not support it.

- 3.3.0
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 3.198% when pulling 7110e5c on scheduler_setup into ab55f04 on master.

@aschnell
Copy link
Member

Is the user informed about the failure to set the scheduler for some devices?

@lslezak
Copy link
Member Author

lslezak commented Aug 14, 2017

No, this is about setting the default scheduler (via elevator= boot parameter). The kernel also does not report failures for devices which do not support this default at boot.

For a device specific setting an error message would be appropriate, for setting the global default it is IMHO OK to set it only where applicable and silently skip the unsupported devices.

The activation is done just to avoid rebooting the machine, it should produce the same result with the same behavior as reboot.

Copy link
Member

@aschnell aschnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit c70293d into master Aug 15, 2017
@lslezak lslezak deleted the scheduler_setup branch August 15, 2017 08:26
@jreidinger jreidinger mentioned this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants