Fixed repository loading (bsc#1163081) #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
requested changes
Feb 21, 2020
- Do not remove the initial installation repository - The Pkg.SourceRestore was no operation when a repository was present, to force it to work the workaround was to call Pkg.SourceFinishAll to forget all repositories. Unfortunately this caused removing the initial installation repository in openSUSE. - See related yast/yast-pkg-bindings#125 - 4.2.17
mvidner
approved these changes
Feb 21, 2020
|
❌ Public Jenkins job #37 failed |
|
✔️ Internal Jenkins job #26 successfully finished |
|
✔️ Public Jenkins job #38 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pkg.SourceRestorewas no operation when a repository was present, to force it to work the workaround was to callPkg.SourceFinishAllto forget all repositories. Unfortunately this caused removing the initial installation repository in openSUSE.Note: the spec file change was introduced in the previous PR #150. I wrongly checked in which packages it was, that caused file conflict (https://ci.suse.de/job/yast-yast-update-master/25/console).