bsc#1180142: do not use 'installation-helper' to create snapshots #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Report the problem to the user and allow to continue.
imobachgs
force-pushed
the
bsc-1180142
branch
from
2638445
to
189ba21
Compare
jreidinger
reviewed
Dec 22, 2020
| "unless you have created a snapshot manually.") | ||
| ) | ||
| ensure | ||
| WFM.SCRSetDefault(original_scr) if original_scr |
There was a problem hiding this comment.
when I see this maybe it would be nice to have block version in ruby bindings itself for such operation?
There was a problem hiding this comment.
but probably just for master
There was a problem hiding this comment.
OK, I will have it into account when merging these changes in master. Thanks for the hint.
jreidinger
approved these changes
Dec 22, 2020
jreidinger
approved these changes
Feb 9, 2021
This was referenced Feb 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FsSnapshotAPI changes introduced in bsc#1180142: do not use 'installation-helper' to create snapshots yast-yast2#1125.