Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the installation repositories after going back #95

Merged
merged 5 commits into from
Mar 15, 2018
Merged

Restore the installation repositories after going back #95

merged 5 commits into from
Mar 15, 2018

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Mar 15, 2018 •
edited

Fix

  • Fixed restoring the initial installation repositories
    • The old code just kept the first repository, that removed all additional repositories (DUD, custom addons)
    • The migration rollback reloads all repositories, that first repository might not be the initial one
    • Now really save the repositories and restore them
  • Tested manually, now you can go back and forth in the upgrade workflow, upgrade the registration to SLE15, downgrade back to SLE12 and try again (with a different or even the same partition)
  • Sorry for the coverage drop, adding the test for the client would require some refactoring... 馃槙
    I'm focused on killing bugs in the RC phase.
  • 4.0.11

Extra Cleanup

  • Cleanup, removed old unused files (I'll update yast2-packager to not use the dropped scripts)
  • Remove the historic unsupported file systems (+ ReiserFS which has been dropped recently)
  • Make sure we run the tests in English locale

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 15.342% when pulling c44f43f on restore_installation_repos into 57159cc on master.

jreidinger
jreidinger reviewed Mar 15, 2018
View reviewed changes
src/bin/remove_junk
if test -d $1/var/lib/YaST2/you ; then
/bin/rm -f $1/var/lib/YaST2/you/quickcheck
/bin/rm -fr $1/var/lib/YaST2/you/{files,installed,mnt,scripts}
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not need this mess if we properly use ghost files in past :)

jreidinger
jreidinger reviewed Mar 15, 2018
View reviewed changes
src/modules/RootPart.rb
@@ -1127,11 +1127,8 @@ def MountFSTab(fstab, message)
"ext3",
"ext4",
"btrfs",
"minix",
"reiserfs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just are you sure that we without this can report error that reiserfs is not supported?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, let me check that...

Copy link
Member Author

@lslezak lslezak Mar 15, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turned out that I still have a SLES10 VM with ReiserFS, so I could test that. 馃檪

And yes it works, the check is actually done at a different place:

sles10_upgrade_reiserfs

@lslezak lslezak merged commit 333b396 into master Mar 15, 2018
@lslezak lslezak deleted the restore_installation_repos branch March 15, 2018 12:35
@lslezak lslezak mentioned this pull request Mar 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lslezak @coveralls @jreidinger