Reduce perl #137
Reduce perl #137
Conversation
| @start_dialog ||= "summary" | ||
| end | ||
|
|
||
| def assign_use_next_time(value) |
There was a problem hiding this comment.
The usual prefixes are get and set, I'm fine with leaving out get but I'd rather prefer set instead of assign, e.g. use set_use_next_time here.
| @@ -3979,7 +3829,6 @@ sub WriteLoginDefaults { | |||
|
|
|||
| ##------------------------------------ | |||
| # Save Security settings (encryption method) if changed in Users module | |||
| BEGIN { $TYPEINFO{WriteSecurity} = ["function", "boolean"]; } | |||
There was a problem hiding this comment.
I'd keep the type data in a comment, it might be useful later when reimplementing in Ruby. Maybe you could use the yardoc format now so the refactoring it will be easier in the future...
There was a problem hiding this comment.
ok, keeping in comment make sense.
|
BTW fix also the spec file, see the Travis log for more details. |
|
@jreidinger do you plan to work on it? There is still some changes pending. If we do not plan to work on it during a while maybe we could close it by now. |
|
@jreidinger closing it by now. Feel free to reopen it if you plan to finish the requested changes. |
No description provided.