Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce perl #137

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@jreidinger
Copy link
Member

commented Feb 28, 2017

No description provided.

@lslezak
Copy link
Member

left a comment

Thanks for touching this tricky Perl part! 👍

@start_dialog ||= "summary"
end

def assign_use_next_time(value)

This comment has been minimized.

Copy link
@lslezak

lslezak Apr 4, 2017

Member

The usual prefixes are get and set, I'm fine with leaving out get but I'd rather prefer set instead of assign, e.g. use set_use_next_time here.

@@ -3979,7 +3829,6 @@ sub WriteLoginDefaults {

##------------------------------------
# Save Security settings (encryption method) if changed in Users module
BEGIN { $TYPEINFO{WriteSecurity} = ["function", "boolean"]; }

This comment has been minimized.

Copy link
@lslezak

lslezak Apr 4, 2017

Member

I'd keep the type data in a comment, it might be useful later when reimplementing in Ruby. Maybe you could use the yardoc format now so the refactoring it will be easier in the future...

This comment has been minimized.

Copy link
@jreidinger

jreidinger Apr 4, 2017

Author Member

ok, keeping in comment make sense.

@lslezak

This comment has been minimized.

Copy link
Member

commented Apr 4, 2017

BTW fix also the spec file, see the Travis log for more details.

@teclator

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2018

@jreidinger do you plan to work on it? There is still some changes pending. If we do not plan to work on it during a while maybe we could close it by now.

@teclator

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2018

@jreidinger closing it by now. Feel free to reopen it if you plan to finish the requested changes.

@teclator teclator closed this Apr 13, 2018

@shundhammer shundhammer deleted the reduce_perl branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.