Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash if root is not defined #157

Merged
merged 3 commits into from
Apr 6, 2018
Merged

Do not crash if root is not defined #157

merged 3 commits into from
Apr 6, 2018

Conversation

imobachgs
Copy link
Contributor

Fixes bsc#1088183.

wfeldt
wfeldt approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@wfeldt wfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wfeldt
Copy link
Member

wfeldt commented Apr 6, 2018 •
edited
Loading

BTW, as mls spotted, these two lines

https://github.com/yast/yast-users/blob/master/src/modules/Users.pm#L53-L54

are clearly wrong. () should probably be {} here. (Compare to similar blobs further below.)

(But this is unrelated to this particular issue.)

@teclator
Copy link
Contributor

teclator commented Apr 6, 2018

LGTM

@imobachgs
Copy link
Contributor Author

Thanks both! We will address what Steffen comments in another PR.

@imobachgs imobachgs merged commit 1b48621 into SLE-12-SP3 Apr 6, 2018
@imobachgs imobachgs mentioned this pull request Apr 6, 2018
Merged
@imobachgs imobachgs deleted the fix-no-root branch April 9, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfeldt wfeldt wfeldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imobachgs @wfeldt @teclator