Fix the user's home creation [bsc#1134970] #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use "use_btrfs_subvolume" in the `Users` Perl module variable must behave as a boolean value. So, it must be managed using the `bool` subroutine to deal "Yast::YCP::Boolean" correctly. Related to https://bugzilla.suse.com/show_bug.cgi?id=1134970
dgdavid
changed the title
dgdavid
commented
May 16, 2019
| @@ -4483,7 +4483,7 @@ sub Write { | |||
|
|
|||
| my %user = %{$modified_users{$type}{$username}}; | |||
| my $home = $user{"homeDirectory"} || ""; | |||
| my $use_btrfs_subvolume = $user{"btrfs_subvolume"} || 0; | |||
| my $use_btrfs_subvolume = bool($user{"btrfs_subvolume"}); | |||
There was a problem hiding this comment.
Note for reviewers: the bool Perl subroutine already returns 0 if $user{"btrfs_subvolume"} is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The user creation does not respect the desired behavior: to create the user's home as a plain directory (default) or as a Btrfs subvolume (ticking the "Create as Btrfs Subvolume" option added in 4.1.7). Instead, it is always - in an installed system - trying to create a Btrfs subvolume (unsuccessfully when the chosen path is no in a Btrfs filesystem).
Why?
Simply because Perl understands the
Yast::YCP::Booleanas a true thing even when its->value()isfalse. That's the reason why it must be used theboolsubroutine, which returns the right value.Solution
To initialize the
$use_btrfs_subvolume"variable properly, using theboolsubroutine mentioned above.Tests