Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request confirmation for aborting in the root password dialog #225

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

teclator
Copy link
Contributor

Problem

During an installation or firstboot configuration, the dialog for setting the root password abort immediately when the Abort button is pressed. It should request an abort confirmation before abort.

Solution

Added the popup for confirming the abort.

Screenshots

AbortRootPasswordSetting

@coveralls
Copy link

Pull Request Test Coverage Report for Build 824

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 31.867%

Totals Coverage Status
Change from base Build 820: 0.06%
Covered Lines: 1094
Relevant Lines: 3433

💛 - Coveralls

@teclator teclator merged commit 0fbae8c into master Mar 13, 2020
@teclator teclator deleted the ask_confirmation_abort branch March 13, 2020 08:50
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #41 successfully finished
✔️ Created OBS submit request #784581

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #10 successfully finished
✔️ Created IBS submit request #213867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants