Use shadow tools in users client #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux writer improvements
Document supported attributes
Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>
Add reader from Users module
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: David Díaz González <dgonzalez@suse.de> Co-authored-by: Ancor Gonzalez Sosa <ancor@suse.de>
Edit users
Add missing files to makefiles
- User.create_system - User#default_home
Using Yast::Execute.on_target! to ensure the check is done against right path in both, installation and running system.
Because it looks more like a use-case for the target agent than one for Yast::Execute. See #352 (comment)
Fix check for user home existence
Read home permissions and root aliases
As it is no longer supported by YaST, it makes no sense to pollute the profile with <group_passsord> and <encrypted> tags in group sections.
As it is no longer supported by YaST, it makes no sense to still trying to import neither, <group_passsord> nor <encrypted> group attributes
9 tasks
Do not support group passwords
The Users module was not reseting its internal data structure for removed elements after each write action. With previous code writing the /etc/passwd and /etc/groups files directly, this was not a problem. It simply didn't write the "deleted" elements. Now that new code is running a "userdel" and "groupdel" commands to remove them, an error for the first previously deleted element is prompted after running a "Write Changes Now" action. Reseting "removed" lists internally at the end of each #Write action fixes the problem.
Always create home
Flush deleted users and groups after each write
ancorgs
approved these changes
Nov 10, 2021
|
✔️ Internal Jenkins job #29 successfully finished |
|
✔️ Public Jenkins job #67 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts YaST users client to use the shadow tools for performing changes into the system.
NOTE: this PR is only about merging the accumulated work. Everything has been already reviewed and manually tested.