Support for alternative YPPWD_SRCDIR #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorgs
force-pushed
the
upstream/yppwd_srcdir_sp4
branch
3 times, most recently
from
39ec130
to
2d392ef
Compare
ancorgs
force-pushed
the
upstream/yppwd_srcdir_sp4
branch
from
2d392ef
to
8d7ca13
Compare
joseivanlopez
approved these changes
May 23, 2023
| # | ||
| # Hopefully, this mixin will disappear (maybe substituted by a similar one) once the shadow | ||
| # tools gain the ability to specify the exact location of the passwd, shadow and groups files. | ||
| module RootPath |
There was a problem hiding this comment.
NP: Maybe this mixin can be part of the Action base class.
The shadow PR got merged today. |
ancorgs
force-pushed
the
upstream/yppwd_srcdir_sp4
branch
from
08800b3
to
7bcbd1d
Compare
|
Added the changelog and version bump, since the updated shadow tools are already accepted. See https://build.suse.de/request/show/303035 and https://build.suse.de/request/show/303036 |
|
✔️ Internal Jenkins job #8 successfully finished |
This was referenced Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In a NIS master server, there is a setting stored at
/etc/sysconfig/ypservand calledYPPWD_SRCDIRthat specifies where are thepasswd,shadowandgroupfiles that NIS should export. By default this points to/etc. So in a typical NIS master server, managing the users and groups of the NIS domain is fully equivalent to managing the local users and groups in the system.But what happens if that setting is set to a non default value?
When YaST Users runs in a system that is a NIS master server with
YPPWD_SRCDIRpointing to an alternative location, it allows the user to select which set of "local users" should be managed in that execution of YaST - the one stored at/etcor the one stored at the location pointed byYPPWD_SRCDIR.Unfortunately, when rewriting YaST Users to rely on the
shadowtools (useraddand friends) we were not aware of that circumstance and YaST always modifies the files under/etc.See https://bugzilla.suse.com/show_bug.cgi?id=1206627
Solution
First step. Make
Linux::Writermore configurable so it can be instructed to write the changes to the files in the directory pointed byYPPWD_SRCDIRSecond step. Modify
Linux::Writerand its action to execute the corresponding commands using the--prefixargument (for all commandsuseradd,userdel,usermod,groupadd,groupdel,groupmod,passwd,chpasswdandchage).Note for reviewer
This involved a previous refactoring to make easier to add new values to the
Linux::Writerconfiguration. Review commit by commit if you want to easily follow the rationale of that refactoring.Testing