Bsc#1091967 #32
Closed
Bsc#1091967 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
reviewed
May 11, 2018
| inst_hyper = Popup.YesNo( | ||
| _("Run 'Install Hypervisor and Tools' to correct this?") | ||
| ) | ||
| if inst_hyper == true |
There was a problem hiding this comment.
you can omit the comparison operator and just check inst_hyper and even do a
return false unless Popup.YesNo(_("Run 'Install Hypervisor and Tools' to correct this?"))But what about the state of ssh, it is not read in this case.
Apart of that ConfigureDom0 needs like a cleanup, huge method with definition of methods inside of it.. I will maybe help refactoring it a little bit in the future and adding some unit tests.
teclator
reviewed
May 11, 2018
| Thu May 10 13:43:20 MDT 2018 - carnold@suse.com | ||
|
|
||
| - bsc#1091967 - relocation-server configuration - error : cannot | ||
| read the current libvirt/sshd state |
There was a problem hiding this comment.
Version is missing, and also a version bump.
rake version:bump
do we plan to release it as part of GA - media? If that is the case then the SLE-15-GA branch should be used instead of master
|
I have two other yast2-vm bugs to merge. Closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.