[SLE15-SP3] Place file selection buttons at the bottom #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
changed the title
lslezak
reviewed
Apr 15, 2020
src/lib/vpn/edit_gw_secrets.rb
Outdated
| @@ -192,10 +192,10 @@ def mk_gw_cert_frame | |||
| Frame(_("Gateway certificate"), VBox( | |||
| Left(MinWidth(40, HBox( | |||
| InputField(Id(:gw_cert), _("Path to certificate file"), ""), | |||
| PushButton(Id(:select_gw_cert), _("Pick.."))))), | |||
| Bottom(PushButton(Id(:select_gw_cert), _("Pick..")))))), | |||
There was a problem hiding this comment.
BTW I'd replace the "Pick" label with Label.Select code - this would be more consistent with the other dialogs and it would save some translators work...
There was a problem hiding this comment.
Thank you @lslezak for the suggestion! I had focused on resolving what was reported in the bug. Could you please check the updated diff and review if it meets the current standard?
|
This mr is missing a version change and a changelog entry. |
This should allow input text boxes and file selection buttons to be aligned.
|
✔️ Public Jenkins job #21 successfully finished |
|
✔️ Internal Jenkins job #16 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow input text boxes and file selection buttons to be
aligned.
Screenshots before change:
For Gateway Certificate
For Client Certificate
Screenshots after the change:
For Gateway Certificate
For Client Certificate
Fixes bsc#1085625