Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require for compile #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add require for compile #38

wants to merge 1 commit into from

Conversation

hexmode
Copy link

@hexmode hexmode commented Feb 8, 2018

Otherwise, if the user hasn't already loaded compile for some reason,
an error will result.

Otherwise, if the user hasn't already loaded compile for some reason,
an error will result.
@joeheyming
Copy link
Contributor

joeheyming commented Mar 5, 2018

Ah, so that is why compilation mode isn't working for helm git grep. This may be related to #31

@hexmode
Copy link
Author

hexmode commented Feb 27, 2019

It looks like the failing checks here have something to do with compiling emacs, not this patch.

@felipebalbi
Copy link

Going back to this old issue here. I noticed that after I switched my emacs configuration to load most packages on demand, helm-git-grep started failing due to missing define-compilation-mode. As a workaround, I've added:

(use-package compile
  :demand t)

to my emacs configuration, but it looks like helm-git-grep should (require 'compile). No?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants