-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace youtube-dl with yt-dlp #117
Comments
So far we don't know if youtube-dl really won't be maintained, also it's still working. |
Sounds reasonable at the moment. I think you could make the final decision only in the future, when, for example, youtube-dl stop working. So it is better to leave this issue open. |
i found that using this repo with the original youtube-dl.zip resource it ended up being unusable on youtube streams(downloads at 50kbps) so i just switched to the yt-dlp resource with this repo and can confirm it is working perfectly again at full speed. |
This patch solves the issue. ytdl-org/youtube-dl#30184 |
updated youtube-dl binary https://github.com/yausername/youtubedl-lazy/releases/download/2021.06.06/youtube_dl.zip To apply the changes you must remove the app data and then update youtube-dl from the app. |
+1 |
Should we switch to yt-dlp? ytdlp-lazy Test yt-dlp |
yt-dlp has been working great for me. |
Yes it is, I added PR #120 to switch to yt-dlp |
I try your repo (befor last update) ... it's work it's work but I not found it on any repository |
Build failed on my fork and in original repo. I will look into the problem later
|
install ndk version |
The local build was successful, I meant the build on jitpack. |
@TechComet BUILD SUCCESSFUL switch-to-yt-dlp-0.1.0-g48806d1-92/build.log jitpack.io/#xibr/youtubedl-android
or
|
added branch for yt-dlp The yt-dlp branch was added in the original repo and the usage method was added in the readme file. dependencies {
implementation 'com.github.yausername.youtubedl-android:library:13a5502c80'
implementation 'com.github.yausername.youtubedl-android:ffmpeg:13a5502c80'
} |
@xibr sorry for the delayed reply. I am fine with the move. I can help review PRs if you create any. |
well, I'll do that maybe before the weekend. |
I suggest you to replace youtube-dl with its successor yt-dlp, because the youtube-dl repository has long been dead and the program partially no longer works, while yt-dlp is actively developing.
Project repository: https://github.com/yt-dlp/yt-dlp
Two issues about the status of the youtube-dl: ytdl-org/youtube-dl#30022 and ytdl-org/youtube-dl#29965
The text was updated successfully, but these errors were encountered: